[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] i440fx-test: guard ARRAY_SIZE definition with
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef |
|
Date: |
Thu, 30 Apr 2015 23:14:06 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 |
30.04.2015 22:16, Emilio G. Cota wrote:
> ARRAY_SIZE is defined in osdep.h so having an unconditional
> definition here is fragile.
Fragile in what sense? Nothing in that file includes osdep.h.
At the maximum, compiler will issue a warning about redefinition
(it should really be redefinition, not the same definition),
which might be treated as error, and we'll just fix that
warning.. I'd say just be done with this, it doesn't deserve
that much attention ;)
Somehow initially I thought this patch actually FIXES a warning
of this sort. But it looks lile it is only fixes a potential
warning. Oh well... :)
Thanks,
/mjt
- [Qemu-trivial] [PULL 11/42] tpm: fix coding style, (continued)
- [Qemu-trivial] [PULL 11/42] tpm: fix coding style, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 15/42] pci: Remove unused function ich9_d2pbr_init(), Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 22/42] libcacard: stop including qemu-common.h, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 36/42] i440fx-test: remove ARRAY_SIZE redefinition, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 21/42] docs/atomics.txt: fix two typos, Michael Tokarev, 2015/04/30
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30, Peter Maydell, 2015/04/30
[Qemu-trivial] [PULL 00/42] Trivial patches for 2015-04-30, Michael Tokarev, 2015/04/30