[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 1/4] hw/display/cg3.c: Fix memory leak
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-trivial] [PATCH 1/4] hw/display/cg3.c: Fix memory leak |
Date: |
Thu, 28 May 2015 20:08:01 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/5/28 19:55, Michael Tokarev wrote:
> 28.05.2015 14:13, Shannon Zhao wrote:
>> > From: Shannon Zhao <address@hidden>
>> >
>> > Signed-off-by: Shannon Zhao <address@hidden>
>> > Signed-off-by: Shannon Zhao <address@hidden>
>> > ---
>> > hw/display/cg3.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/hw/display/cg3.c b/hw/display/cg3.c
>> > index 1e6ff2b..b86e5c0 100644
>> > --- a/hw/display/cg3.c
>> > +++ b/hw/display/cg3.c
>> > @@ -302,6 +302,7 @@ static void cg3_realizefn(DeviceState *dev, Error
>> > **errp)
>> > if (fcode_filename) {
>> > ret = load_image_targphys(fcode_filename, s->prom_addr,
>> > FCODE_MAX_ROM_SIZE);
>> > + g_free(fcode_filename);
>> > if (ret < 0 || ret > FCODE_MAX_ROM_SIZE) {
>> > error_report("cg3: could not load prom '%s'", CG3_ROM_FILE);
>> > }
> BTW, here, maybe it is better to rework error message too,
> to include the actual filename it tried to load, not the
> base name of it.
>
So respin this and other patches?
> Is the error fatal?
If CG3_ROM_FILE is removed, it happens.
--
Shannon