[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] configure: don't apply -O2 if extra-cflags se
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [PATCH] configure: don't apply -O2 if extra-cflags sets -O |
|
Date: |
Fri, 29 May 2015 18:29:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 29/05/2015 16:14, Alex Bennée wrote:
> You mean just do:
>
> diff --git a/configure b/configure
> index b707429..f13831a 100755
> --- a/configure
> +++ b/configure
> @@ -353,7 +353,7 @@ for opt do
> ;;
> --cpu=*) cpu="$optarg"
> ;;
> - --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
> + --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
> EXTRA_CFLAGS="$optarg"
> ;;
> --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"
>
> I guess at the time I was trying to be clean and avoiding multiple -O
> calls. But I guess that will have the same effect.
Yes, that. Most other QEMU_CFLAGS assignments add at the beginning, so
I guess the remaining ones (including the --extra-cflags one) should too.
Paolo