[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 29/29] hw/s390x/sclpcpu.c: Fix memory leak spo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH 29/29] hw/s390x/sclpcpu.c: Fix memory leak spotted by valgrind |
Date: |
Sat, 30 May 2015 12:34:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 28/05/2015 14:08, Shannon Zhao wrote:
> -static qemu_irq *irq_cpu_hotplug; /* Only used in this file */
> +static qemu_irq irq_cpu_hotplug; /* Only used in this file */
>
> #define EVENT_QUAL_CPU_CHANGE 1
>
> void raise_irq_cpu_hotplug(void)
> {
> - qemu_irq_raise(*irq_cpu_hotplug);
> + qemu_irq_raise(irq_cpu_hotplug);
> }
>
> static unsigned int send_mask(void)
> @@ -81,7 +81,10 @@ static void trigger_signal(void *opaque, int n, int level)
>
> static int irq_cpu_hotplug_init(SCLPEvent *event)
> {
> - irq_cpu_hotplug = qemu_allocate_irqs(trigger_signal, event, 1);
> + qemu_irq irq = qemu_allocate_irq(trigger_signal, event, 0);
> +
> + irq_cpu_hotplug = irq;
> + qemu_free_irq(irq);
> return 0;
This is wrong, you cannot free the IRQ after you have stored it in
irq_cpu_hotplug.
Paolo
- [Qemu-trivial] [PATCH 26/29] hw/arm/spitz.c: Fix memory leak spotted by valgrind, (continued)
- [Qemu-trivial] [PATCH 26/29] hw/arm/spitz.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 24/29] hw/arm/omap_sx1.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 23/29] hw/arm/nseries.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 21/29] hw/sh4/r2d.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 29/29] hw/s390x/sclpcpu.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 27/29] hw/arm/tosa.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 28/29] hw/display/tc6393xb.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 03/29] hw/i386/pc: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 02/29] hw/ide/cmd646.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH 04/29] hw/i386/pc_q35.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- Re: [Qemu-trivial] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs, Michael Tokarev, 2015/05/28