Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC

[Wen Congyang]

On 07/23/2015 01:53 AM, Stefan Weil wrote:
> This regression was caused by commit 70b94331.

vnc, not vlc in the title.

Reviewed-by: Wen Congyang <address@hidden>

> 
>   CC    vl.o
> vl.c: In function ‘select_display’:
> vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable]
>      Error *err = NULL;
>             ^
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 5856396..0adbbd6 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2061,7 +2061,6 @@ static void select_vgahw (const char *p)
>  
>  static DisplayType select_display(const char *p)
>  {
> -    Error *err = NULL;
>      const char *opts;
>      DisplayType display = DT_DEFAULT;
>  
> @@ -2130,6 +2129,7 @@ static DisplayType select_display(const char *p)
>      } else if (strstart(p, "vnc", &opts)) {
>  #ifdef CONFIG_VNC
>          if (*opts == '=') {
> +            Error *err = NULL;
>              if (vnc_parse(opts + 1, &err) == NULL) {
>                  error_report_err(err);
>                  exit(1);
>