[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 17/19] linux-user: Use g_new() & friends where that
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 17/19] linux-user: Use g_new() & friends where that makes obvious sense |
Date: |
Thu, 8 Oct 2015 19:52:26 +0300 |
From: Markus Armbruster <address@hidden>
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
sizeof(T). Same Coccinelle semantic patch as in commit b45c03f.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
linux-user/elfload.c | 2 +-
linux-user/main.c | 2 +-
linux-user/syscall.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index fdae6a6..d68f5a1 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2853,7 +2853,7 @@ static int fill_note_info(struct elf_note_info *info,
TaskState *ts = (TaskState *)cpu->opaque;
int i;
- info->notes = g_malloc0(NUMNOTES * sizeof (struct memelfnote));
+ info->notes = g_new0(struct memelfnote, NUMNOTES);
if (info->notes == NULL)
return (-ENOMEM);
info->prstatus = g_malloc0(sizeof (*info->prstatus));
diff --git a/linux-user/main.c b/linux-user/main.c
index d6af7ca..8acfe0f 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -4270,7 +4270,7 @@ int main(int argc, char **argv, char **envp)
}
target_argv[target_argc] = NULL;
- ts = g_malloc0 (sizeof(TaskState));
+ ts = g_new0(TaskState, 1);
init_task_state(ts);
/* build Task State */
ts->info = info;
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 98b5766..b8ce208 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -4566,7 +4566,7 @@ static int do_fork(CPUArchState *env, unsigned int flags,
abi_ulong newsp,
new_thread_info info;
pthread_attr_t attr;
- ts = g_malloc0(sizeof(TaskState));
+ ts = g_new0(TaskState, 1);
init_task_state(ts);
/* we create a new CPU instance. */
new_env = cpu_copy(env);
--
2.1.4
- [Qemu-trivial] [PULL 00/19] Trivial patches for 2015-10-08, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 10/19] target-ppc: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 03/19] sdhci: Change debug prints to compile unconditionally, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 12/19] qapi: add missing @, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 09/19] target-microblaze: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 14/19] hw: char: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 13/19] hw: timer: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 05/19] block/ssh: remove dead code, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 07/19] pc: check for underflow in load_linux, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 17/19] linux-user: Use g_new() & friends where that makes obvious sense,
Michael Tokarev <=
- [Qemu-trivial] [PULL 02/19] sdhci: use PRIx64 for uint64_t type, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 11/19] MAINTAINERS: Add NSIS file for W32, W64 hosts, Michael Tokarev, 2015/10/08
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/19] Trivial patches for 2015-10-08, Peter Maydell, 2015/10/09
- [Qemu-trivial] [PULL 01/19] Add .dir-locals.el file to configure emacs coding style, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 16/19] rocker: Use g_new() & friends where that makes obvious sense, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 04/19] imx_serial: Generate interrupt on tx empty if enabled, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 08/19] s/cpu_get_real_ticks/cpu_get_host_ticks/, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 06/19] pci-assign: do not include sys/io.h, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 18/19] linux-user: Remove type casts to union type, Michael Tokarev, 2015/10/09