qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/5] hw/input/tsc210x: Remove sup


From: Thomas Huth
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/5] hw/input/tsc210x: Remove superfluous memset
Date: Fri, 9 Oct 2015 08:40:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 09/10/15 01:34, Eric Blake wrote:
> On 10/08/2015 01:35 PM, Thomas Huth wrote:
>> g_malloc0 already clears the memory, so no need for additional
>> memsets here. And while we're at it, let's also remove the
>> superfluous typecasts for the return values of g_malloc0.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  hw/input/tsc210x.c | 8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
>> index fae3385..92b076a 100644
>> --- a/hw/input/tsc210x.c
>> +++ b/hw/input/tsc210x.c
>> @@ -1086,9 +1086,7 @@ uWireSlave *tsc2102_init(qemu_irq pint)
>>  {
>>      TSC210xState *s;
>>  
>> -    s = (TSC210xState *)
>> -            g_malloc0(sizeof(TSC210xState));
>> -    memset(s, 0, sizeof(TSC210xState));
>> +    s = g_malloc0(sizeof(TSC210xState));
> 
> This should probably be g_new0(TSC210xState, 1), consistent with Markus'
> recent cleanup patches.

Ok, I'll change my patch.

 Thomas


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]