[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] fix bad indentation in pcie_cap_slot_write_co
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] fix bad indentation in pcie_cap_slot_write_config() |
|
Date: |
Thu, 29 Oct 2015 11:07:49 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
29.10.2015 10:57, Cao jin wrote:
> Thanks Michael. and I am sorry if it bothered you.
There's nothing to worry about, really.
> Maybe it can be avoid to have a clear definition of "trivial" to direct the
> newbies like me:P
It is a general common sense maybe, I dunno. There's lot of code which does not
comply with the coding styles, and at the very least, when you change just that
without actually changing the code, git blame stops working, showing your non-
change for everything instead of showing actual _code_ changes. That's one of
the reasons why all qemu codebase hasn't been translated by some automatic
coding style formatting tool.
Thanks,
/mjt