[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes |
Date: |
Fri, 27 Nov 2015 15:39:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical
> reasons these do not use sizeof, and Coverity caught a mistake in
> EVT_ENCRYPT_CHANGE_SIZE.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/hw/bt.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/bt.h b/include/hw/bt.h
> index cb2a7e6..bbea104 100644
> --- a/include/hw/bt.h
> +++ b/include/hw/bt.h
> @@ -1266,7 +1266,7 @@ typedef struct {
> uint8_t status;
> uint16_t handle;
> } QEMU_PACKED reset_failed_contact_counter_rp;
> -#define RESET_FAILED_CONTACT_COUNTER_RP_SIZE 4
> +#define RESET_FAILED_CONTACT_COUNTER_RP_SIZE 3
>
> #define OCF_READ_LINK_QUALITY 0x0003
> typedef struct {
> @@ -1381,7 +1381,7 @@ typedef struct {
> uint16_t handle;
> uint8_t encrypt;
> } QEMU_PACKED evt_encrypt_change;
> -#define EVT_ENCRYPT_CHANGE_SIZE 5
> +#define EVT_ENCRYPT_CHANGE_SIZE 4
>
> #define EVT_CHANGE_CONN_LINK_KEY_COMPLETE 0x09
> typedef struct {
Yuck!
Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you
checked them all.
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-trivial] [PATCH for-2.5] bt: fix two struct sizes, Paolo Bonzini, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes,
Markus Armbruster <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Paolo Bonzini, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Markus Armbruster, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Paolo Bonzini, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Markus Armbruster, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Markus Armbruster, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Paolo Bonzini, 2015/11/27
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes, Markus Armbruster, 2015/11/27