qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepa


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath
Date: Sat, 30 Jan 2016 12:51:27 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0

22.01.2016 20:35, Daniel P. Berrange wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.

Applied to -trivial, fixed qemu-devel@ addres.

Thanks!

/mjt

> Tested-by: Sean Bruno <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  qemu-char.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, 
> void *arg)
>  }
>  
>  static CharDriverState *qemu_chr_open_pp_fd(int fd,
> -                                            ChardevBackend *backend,
> +                                            ChardevCommon *backend,
>                                              Error **errp)
>  {
>      CharDriverState *chr;
>  
> -    chr = qemu_chr_alloc(common, errp);
> +    chr = qemu_chr_alloc(backend, errp);
>      if (!chr) {
>          return NULL;
>      }
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]