[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the d
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support |
|
Date: |
Thu, 04 Feb 2016 07:03:33 +0000 |
|
User-agent: |
mu4e 0.9.17; emacs 25.0.90.1 |
Peter Maydell <address@hidden> writes:
> On 3 February 2016 at 18:54, Alex Bennée <address@hidden> wrote:
>> It preserves the old behaviour (and the general behaviour of DEBUG_FOO
>> going to stderr). However I'm happy to make it default to using the log
>> output.
>>
>> It does raise the question of if we should just enable the debugging by
>> default?
>
> Not without thinking carefully about it. This is programmer
> debug code for figuring out what's happening in a performance
> sensitive bit of code. "Just print to stderr" is the classic
> way to do this, and I don't think we should just convert that
> into userfacing trace.
Shall I just go back to the original fprintf output then? I made the
output optional a few review comments back.
>
> There may be useful user facing trace we can do of TLB
> operations but I wouldn't assume that our current debug
> printfs are it.
>
> thanks
> -- PMM
--
Alex Bennée