[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH v2 4/5] replace muldiv64(a, b, c) by (uint64_t)a *
From: |
Laurent Vivier |
Subject: |
[Qemu-trivial] [PATCH v2 4/5] replace muldiv64(a, b, c) by (uint64_t)a * b / c |
Date: |
Mon, 9 May 2016 15:24:58 +0200 |
When "a" and "b" are 32bit values, we don't have to cast
them to 128bit, 64bit is enough.
This patch is the result of coccinelle script
scripts/coccinelle/simplify_muldiv64.cocci
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/audio/gus.c | 2 +-
hw/xtensa/pic_cpu.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/audio/gus.c b/hw/audio/gus.c
index 9dd6947..6c02646 100644
--- a/hw/audio/gus.c
+++ b/hw/audio/gus.c
@@ -144,7 +144,7 @@ static void GUS_callback (void *opaque, int free)
s->left = samples;
reset:
- gus_irqgen (&s->emu, muldiv64 (net, 1000000, s->freq));
+ gus_irqgen (&s->emu, (uint64_t)net * 1000000 / s->freq);
}
int GUS_irqrequest (GUSEmuState *emu, int hwirq, int n)
diff --git a/hw/xtensa/pic_cpu.c b/hw/xtensa/pic_cpu.c
index c835bd0..343ea2c 100644
--- a/hw/xtensa/pic_cpu.c
+++ b/hw/xtensa/pic_cpu.c
@@ -121,8 +121,8 @@ void xtensa_rearm_ccompare_timer(CPUXtensaState *env)
}
env->wake_ccount = wake_ccount;
timer_mod(env->ccompare_timer, env->halt_clock +
- muldiv64(wake_ccount - env->sregs[CCOUNT],
- 1000000, env->config->clock_freq_khz));
+ (uint64_t)(wake_ccount - env->sregs[CCOUNT]) *
+ 1000000 / env->config->clock_freq_khz);
}
static void xtensa_ccompare_cb(void *opaque)
--
2.5.5
- [Qemu-trivial] [PATCH v2 0/5] muldiv64() trivial fixes, Laurent Vivier, 2016/05/09
- [Qemu-trivial] [PATCH v2 1/5] scripts: add muldiv64() checking coccinelle scripts, Laurent Vivier, 2016/05/09
- [Qemu-trivial] [PATCH v2 2/5] The only 64bit parameter of muldiv64() is the first one., Laurent Vivier, 2016/05/09
- [Qemu-trivial] [PATCH v2 3/5] remove useless muldiv64(), Laurent Vivier, 2016/05/09
- [Qemu-trivial] [PATCH v2 4/5] replace muldiv64(a, b, c) by (uint64_t)a * b / c,
Laurent Vivier <=
- [Qemu-trivial] [PATCH v2 5/5] ppc: Remove a potential overflow in muldiv64(), Laurent Vivier, 2016/05/09
- Re: [Qemu-trivial] [PATCH v2 0/5] muldiv64() trivial fixes, Michael Tokarev, 2016/05/29