qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 05/16] block: Use DIV_ROUND_UP


From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 05/16] block: Use DIV_ROUND_UP
Date: Tue, 31 May 2016 11:50:50 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 05/31/2016 10:35 AM, Laurent Vivier wrote:
> Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d).
> 
> This patch is the result of coccinelle script
> scripts/coccinelle/round.cocci
> 
> CC: address@hidden
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  block/vvfat.c      | 3 +--
>  hw/block/tc58128.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index a39dbe6..6d2e21c 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1960,8 +1960,7 @@ DLOG(fprintf(stderr, "check direntry %d:\n", i); 
> print_direntry(direntries + i))
>               /* check file size with FAT */
>               cluster_count = get_cluster_count_for_direntry(s, direntries + 
> i, path2);
>               if (cluster_count !=
> -                     (le32_to_cpu(direntries[i].size) + s->cluster_size
> -                      - 1) / s->cluster_size) {
> +            DIV_ROUND_UP(le32_to_cpu(direntries[i].size), s->cluster_size)) {

The tab-vs.-space issues in this file make the patch look weird.  It's
not your fault, but you may want to manually touch up the result so that
visual indentation under 8-spaces-per-tab still looks okay.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]