[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/net: Fix a heap overflow in x
From: |
no-reply |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/net: Fix a heap overflow in xlnx.xps-ethernetlite |
Date: |
Mon, 8 Aug 2016 19:32:44 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] hw/net: Fix a heap overflow in
xlnx.xps-ethernetlite
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f29edf0 hw/net: Fix a heap overflow in xlnx.xps-ethernetlite
=== OUTPUT BEGIN ===
Checking PATCH 1/1: hw/net: Fix a heap overflow in xlnx.xps-ethernetlite...
ERROR: space prohibited before that close parenthesis ')'
#26: FILE: hw/net/xilinx_ethlite.c:200:
+ if (size > (R_MAX - R_RX_BUF0 - rxbase) * 4 ) {
ERROR: Missing Signed-off-by: line(s)
total: 2 errors, 0 warnings, 10 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden