[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] target-lm32: fix style issue
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-trivial] [PATCH] target-lm32: fix style issue |
|
Date: |
Wed, 12 Oct 2016 18:29:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12.10.2016 18:23, Michael Walle wrote:
> Both branches of the ternary operator have the same expressions. Drop the
> operator.
>
> This fixes: https://bugs.launchpad.net/qemu/+bug/1414293
>
> Signed-off-by: Michael Walle <address@hidden>
> ---
> target-lm32/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index 2d8caeb..534c17c 100644
> --- a/target-lm32/translate.c
> +++ b/target-lm32/translate.c
> @@ -343,7 +343,7 @@ static void dec_calli(DisasContext *dc)
> static inline void gen_compare(DisasContext *dc, int cond)
> {
> int rX = (dc->format == OP_FMT_RR) ? dc->r2 : dc->r1;
> - int rY = (dc->format == OP_FMT_RR) ? dc->r0 : dc->r0;
> + int rY = dc->r0;
> int rZ = (dc->format == OP_FMT_RR) ? dc->r1 : -1;
> int i;
Reviewed-by: Thomas Huth <address@hidden>
signature.asc
Description: OpenPGP digital signature