[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] util/mmap-alloc: check parameter
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] util/mmap-alloc: check parameter before using |
|
Date: |
Wed, 26 Oct 2016 08:33:37 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/26/2016 02:18 AM, Cao jin wrote:
> Also refactor some code hunk for readability
>
> Signed-off-by: Cao jin <address@hidden>
> ---
> util/mmap-alloc.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c
> index 5a85aa3..92c123a 100644
> --- a/util/mmap-alloc.c
> +++ b/util/mmap-alloc.c
> @@ -41,6 +41,11 @@ size_t qemu_fd_getpagesize(int fd)
>
> void *qemu_ram_mmap(int fd, size_t size, size_t align, bool shared)
> {
> + /* Make sure align is a power of 2 */
> + assert(!(align & (align - 1)));
Better to spell this:
assert(is_power_of_2(align));
at which point the comment is redundant and can be omitted.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature