Re: [Qemu-trivial] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default

[Adrian Bunk]

On Mon, Nov 28, 2016 at 04:05:33PM +0100, Paolo Bonzini wrote:
> 
> 
> On 27/11/2016 17:28, Adrian Bunk wrote:
> > Building qemu fails in distributions where gcc enables PIE
> > by default (e.g. Debian unstable) with:
> > /usr/bin/ld: -r and -pie may not be used together
> > 
> > -r and -pie cannot be used together in the linker,
> > and position independent is already relocatable.
> > 
> > Use -r instead of -Wl,-r to avoid gcc passing -r to the
> > linker when PIE is enabled.
> > 
> > Signed-off-by: Adrian Bunk <address@hidden>
> 
> I think this is a bug in the linker.  If the linker is producing
> relocatable objects by default, it has no reason to refuse -r.  Have you
> tried asking the binutils folks about it too?

The linker knows nothing about this default, gcc is passing -pie
to the linker.

>...
> Paolo
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed