[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: remove dead check
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: remove dead check |
|
Date: |
Wed, 4 Jan 2017 10:49:00 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 01/04/2017 08:56 AM, Paolo Bonzini wrote:
> options must be non-NULL here, because it has been checked before.
> Reported by Coverity.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qemu-img.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
(not shown in the diff, but several lines earlier, is:
if (!options) {
error_exit("Must specify options (-o)");
}
)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature