[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks f
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 |
|
Date: |
Tue, 31 Jan 2017 18:27:10 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 31/01/2017 12:40, Markus Armbruster wrote:
>>
>> #define QEMU_NORETURN __attribute__ ((__noreturn__))
>>
>> -#if QEMU_GNUC_PREREQ(3, 4)
>> #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
>> -#else
>> -#define QEMU_WARN_UNUSED_RESULT
>> -#endif
> Should we inline this macro?
>
>>
>> -#if QEMU_GNUC_PREREQ(4, 0)
>> #define QEMU_SENTINEL __attribute__((sentinel))
>> -#else
>> -#define QEMU_SENTINEL
>> -#endif
> Likewise.
Why, since we don't do that for QEMU_NORETURN, QEMU_PACKED, etc.?
Paolo