[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Removed header qemu-common.h fro
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Removed header qemu-common.h from path.c |
|
Date: |
Fri, 3 Mar 2017 13:25:03 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
[adding qemu-trivial in cc]
On 03/03/2017 01:18 PM, Suramya Shah wrote:
> Signed-off-by: Suramya Shah <address@hidden>
> ---
It would have been nice to mention in the subject that this is v2 (v1
was here
https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg00110.html),
and then mention here after the --- that the difference was a fix of a
typo that broke compilation.
Also, the subject line doesn't follow the usual conventions of "topic:
Description", a topic of 'util: ' may be appropriate.
> util/path.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/util/path.c b/util/path.c
> index 5479f76..7f9fc27 100644
> --- a/util/path.c
> +++ b/util/path.c
> @@ -6,7 +6,6 @@
> #include "qemu/osdep.h"
> #include <sys/param.h>
> #include <dirent.h>
> -#include "qemu-common.h"
> #include "qemu/cutils.h"
> #include "qemu/path.h"
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature