[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp: allow setting properties to
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp: allow setting properties to empty string in qmp-shell |
|
Date: |
Mon, 06 Mar 2017 09:19:49 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Daniel P. Berrange" <address@hidden> writes:
> The qmp-shell property parser currently rejects attempts to
> set string properties to the empty string eg
>
> (QEMU) migrate-set-parameters tls-hostname=
> Error while parsing command line: Expected a key=value pair, got
> 'tls-hostname='
> command format: <command-name> [arg-name1=arg1] ... [arg-nameN=argN]
>
> This is caused by checking the wrong condition after splitting
> the parameter on '='. The "partition" method will return "" for
> the separator field, if the seperator was not present, so that
> is the correct thing to check for malformed syntax.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
I'll take this through my tree, unless qemu-trivial beats me to the
punch. Thanks!