[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH V1] fix coding style in migration
From: |
Alexey Perevalov |
Subject: |
[Qemu-trivial] [PATCH V1] fix coding style in migration |
Date: |
Fri, 28 Apr 2017 15:44:51 +0300 |
Hello, this is a trivial patch which fixes coding style issues.
But it fixes not all coding style issues. Following issues were omitted:
- ERROR: __func__ should be used instead of gcc specific __FUNCTION__
in migration/block.c
- ERROR: consider using qemu_strtol in preference to strtol
This was not included, due to I tried to not change logic. Maybe it will be in
the next patch.
- WARNING: architecture specific defines should be avoided
I found a lot of #ifdef __linux__, as I assume checkpatch script expects
linux specific code in separate file_linux.c and separation in Makefiles.
- ERROR: spaces required around that '*'
Looks like it's false positive in
#362: FILE: savevm.c:362:
+ .subsections = (const VMStateDescription*[]) {
Alexey Perevalov (1):
migration: Fixed code style
migration/exec.c | 3 ++-
migration/migration.c | 6 +++---
migration/postcopy-ram.c | 2 +-
migration/ram.c | 13 ++++++++-----
migration/rdma.c | 23 ++++++++++++++---------
migration/savevm.c | 9 ++++++---
migration/vmstate.c | 10 +++++-----
7 files changed, 39 insertions(+), 27 deletions(-)
--
1.9.1
- [Qemu-trivial] [PATCH V1] fix coding style in migration,
Alexey Perevalov <=