qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Detect native NetBSD


From: Kamil Rytarowski
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Detect native NetBSD curses(3)
Date: Sun, 21 May 2017 01:17:57 +0200
User-agent: Mozilla/5.0 (X11; NetBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Ping? Could someone please put it on the pull-request?

Adding address@hidden

On 08.05.2017 13:33, Alex Bennée wrote:
> 
> Kamil Rytarowski <address@hidden> writes:
> 
>> NetBSD ships with traditional BSD curses with compatibility with ncurses.
>> qemu works nicely with the basesystem version of curses(3) from NetBSD.
>>
>> The only mismatch between curses(3) and ncurses is the lack of
>> curses_version() in the NetBSD version. This function is used solely in
>> the configure script, therefore eliminate it from the curses(3) detection.
>>
>> With this change applied, configure detects correctly curses frontend.
>>
>> Signed-off-by: Kamil Rytarowski <address@hidden>
> 
> Reviewed-by: Alex Bennée <address@hidden>
> 
>> ---
>>  configure | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index c35acf1192..17dc7224f7 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3034,14 +3034,13 @@ if test "$curses" != "no" ; then
>>  #include <curses.h>
>>  #include <wchar.h>
>>  int main(void) {
>> -  const char *s = curses_version();
>>    wchar_t wch = L'w';
>>    setlocale(LC_ALL, "");
>>    resize_term(0, 0);
>>    addwstr(L"wide chars\n");
>>    addnwstr(&wch, 1);
>>    add_wch(WACS_DEGREE);
>> -  return s != 0;
>> +  return 0;
>>  }
>>  EOF
>>    IFS=:
> 
> 
> --
> Alex Bennée
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]