Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

[John Snow]

On 05/23/2017 03:25 AM, Thomas Huth wrote:
> On 22.05.2017 17:58, address@hidden wrote:
>> This series failed automatic build test. Please find the testing commands and
>> their output below. If you have docker installed, you can probably reproduce 
>> it
>> locally.
> [...]
>>       LEX convert-dtsv0-lexer.lex.c
>>       DEP /tmp/qemu-test/src/dtc/fdtdump.c
>> make[1]: flex: Command not found
>>       BISON dtc-parser.tab.c
>> make[1]: bison: Command not found
>>       DEP /tmp/qemu-test/src/dtc/srcpos.c
>>       LEX dtc-lexer.lex.c
>> make[1]: flex: Command not found
>>       DEP /tmp/qemu-test/src/dtc/treesource.c
>>       DEP /tmp/qemu-test/src/dtc/livetree.c
>>       DEP /tmp/qemu-test/src/dtc/fstree.c
>>       DEP /tmp/qemu-test/src/dtc/flattree.c
>>       DEP /tmp/qemu-test/src/dtc/dtc.c
>>       DEP /tmp/qemu-test/src/dtc/data.c
>>       DEP /tmp/qemu-test/src/dtc/checks.c
>>      CHK version_gen.h
>>       BISON dtc-parser.tab.c
>> make[1]: bison: Command not found
>>       LEX convert-dtsv0-lexer.lex.c
>>      UPD version_gen.h
>> make[1]: flex: Command not found
>>       LEX dtc-lexer.lex.c
>> make[1]: flex: Command not found
>>       DEP /tmp/qemu-test/src/dtc/util.c
>>       LEX convert-dtsv0-lexer.lex.c
>>       BISON dtc-parser.tab.c
>> make[1]: flex: Command not found
>> make[1]: bison: Command not found
>>       LEX dtc-lexer.lex.c
>> make[1]: flex: Command not found
> 
> Looks like flex and bison are missing in the docker image? Could someone
> please add it?
> 
> [...]
>>   CC      replay/replay-internal.o
>> /tmp/qemu-test/src/replay/replay-internal.c: In function ‘replay_put_array’:
>> /tmp/qemu-test/src/replay/replay-internal.c:65: warning: ignoring return 
>> value of ‘fwrite’, declared with attribute warn_unused_result
> 
> I guess that should be fixed?
> 
> [...]
>>   CC      slirp/tcp_input.o
>>   CC      slirp/tcp_output.o
>>   CC      slirp/tcp_subr.o
>>   CC      slirp/tcp_timer.o
>> /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’:
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_len’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_tos’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_id’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_off’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_ttl’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_sum’ may be 
>> used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_src.s_addr’ 
>> may be used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_dst.s_addr’ 
>> may be used uninitialized in this function
>> /tmp/qemu-test/src/slirp/tcp_input.c:220: warning: ‘save_ip6.ip_nh’ may be 
>> used uninitialized in this function
> 
> I've never seen these warnings in tcp_input.c before ... and they also
> look like false positives too me ... is that GCC in the docker image too
> sensitive?
> 
> [...]
>>   CC      aarch64-softmmu/hw/timer/exynos4210_rtc.o
>> /tmp/qemu-test/src/hw/i386/pc_piix.c: In function 
>> ‘igd_passthrough_isa_bridge_create’:
>> /tmp/qemu-test/src/hw/i386/pc_piix.c:1067: warning: ‘pch_rev_id’ may be used 
>> uninitialized in this function
> 
> dito
> 
>>   CC      aarch64-softmmu/hw/usb/tusb6010.o
>> /tmp/qemu-test/src/hw/i386/acpi-build.c: In function 
>> ‘build_append_pci_bus_devices’:
>> /tmp/qemu-test/src/hw/i386/acpi-build.c:525: warning: ‘notify_method’ may be 
>> used uninitialized in this function
> 
> dito
> 
> [...]
>> /tmp/qemu-test/src/tests/ide-test.c: In function ‘cdrom_pio_impl’:
>> /tmp/qemu-test/src/tests/ide-test.c:803: warning: ignoring return value of 
>> ‘fwrite’, declared with attribute warn_unused_result
>> /tmp/qemu-test/src/tests/ide-test.c: In function ‘test_cdrom_dma’:
>> /tmp/qemu-test/src/tests/ide-test.c:899: warning: ignoring return value of 
>> ‘fwrite’, declared with attribute warn_unused_result
> 
> Needs a patch, I guess?
> 

Huh, I've never seen these come up locally, I'll send a patch (if only
to quiet patchew.)

>>   GTESTER tests/test-vmstate
>> Failed to load simple/primitive:b_1
>> Failed to load simple/primitive:i64_2
>> Failed to load simple/primitive:i32_1
>> Failed to load simple/primitive:i32_1
>> Failed to load test/with_tmp:a
>> Failed to load test/tmp_child_parent:f
>> Failed to load test/tmp_child:parent
>> Failed to load test/with_tmp:tmp
>> Failed to load test/tmp_child:diff
>> Failed to load test/with_tmp:tmp
>> Failed to load test/tmp_child:diff
>> Failed to load test/with_tmp:tmp
> 
> That works for me when I run "make check" locally ... could my patch
> have broken this, or is there something else wrong in the repository or
> docker image?
> 
> [...]
>>   GTESTER tests/test-qga
>>   GTESTER tests/test-timed-average
>>   GTESTER tests/test-io-task
>>   GTESTER tests/test-io-channel-socket
>>   GTESTER tests/test-io-channel-file
>>   GTESTER tests/test-io-channel-command
>>   GTESTER tests/test-io-channel-buffer
>>   GTESTER tests/test-base64
>>   GTESTER tests/test-crypto-ivgen
>>   GTESTER tests/test-crypto-afsplit
>>   GTESTER tests/test-crypto-xts
>>   GTESTER tests/test-crypto-block
>>   GTESTER tests/test-logging
>>   GTESTER tests/test-replication
>>   GTESTER tests/test-bufferiszero
>>   GTESTER tests/test-uuid
>>   GTESTER tests/ptimer-test
>>   GTESTER tests/test-qapi-util
>>   GTESTER check-qtest-x86_64
>>   GTESTER check-qtest-aarch64
>>   GTESTER tests/test-qobject-output-visitor
>>   GTESTER tests/test-clone-visitor
>>   GTESTER tests/test-qobject-input-visitor
>>   GTESTER tests/test-qmp-commands
>>   GTESTER tests/test-string-input-visitor
>>   GTESTER tests/test-string-output-visitor
>>   GTESTER tests/test-qmp-event
>>   GTESTER tests/test-opts-visitor
>>   GTESTER tests/test-qht-par
>> qemu-system-aarch64: warning: CPU(s) not present in any NUMA nodes: CPU 2 
>> [thread-id: 2], CPU 3 [thread-id: 3], CPU 6 [thread-id: 6], CPU 7 
>> [thread-id: 7]
>> qemu-system-aarch64: warning: All CPU(s) up to maxcpus should be described 
>> in NUMA config, ability to start up with partial NUMA mappings is obsoleted 
>> and will be removed in future
>> **
>> ERROR:/tmp/qemu-test/src/tests/test-qga.c:894:test_qga_guest_exec: assertion 
>> failed: (exited)
>> GTester: last random seed: R02S88fe048bce3aa693228ab12699fc6771
>> make: *** [check-tests/test-qga] Error 1
>> make: *** Waiting for unfinished jobs....
> 
> I also can not reproduce this here when running "make check". I also can
> not see how this should be related to my patch ... could it be that the
> docker image was simply running into some time out problems here 'cause
> the server was overloaded? In that case we should maybe increase the
> timeout value in test_qga_guest_exec() ?
> 
>  Thomas
> 
>