Re: [Qemu-trivial] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device

[Marcel Apfelbaum]

On 13/06/2017 22:48, Thomas Huth wrote:
> This way the bridge shows up in the correct section of the
> "-device help" text.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>   hw/pci-bridge/dec.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c
> index cca9362..eb275e1 100644
> --- a/hw/pci-bridge/dec.c
> +++ b/hw/pci-bridge/dec.c
> @@ -62,6 +62,7 @@ static void dec_21154_pci_bridge_class_init(ObjectClass 
> *klass, void *data)
>       DeviceClass *dc = DEVICE_CLASS(klass);
>       PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>   
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>       k->realize = dec_pci_bridge_realize;
>       k->exit = pci_bridge_exitfn;
>       k->vendor_id = PCI_VENDOR_ID_DEC;
> @@ -118,6 +119,7 @@ static void dec_21154_pci_host_class_init(ObjectClass 
> *klass, void *data)
>       PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>       DeviceClass *dc = DEVICE_CLASS(klass);
>   
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>       k->realize = dec_21154_pci_host_realize;
>       k->vendor_id = PCI_VENDOR_ID_DEC;
>       k->device_id = PCI_DEVICE_ID_DEC_21154;



Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel