[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v11 6/6] trace: [trivial] Statically enable al
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [PATCH v11 6/6] trace: [trivial] Statically enable all guest events |
|
Date: |
Fri, 7 Jul 2017 06:33:37 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/07/2017 02:34 AM, Lluís Vilanova wrote:
> Eric Blake writes:
>
>> On 07/04/2017 03:54 AM, Lluís Vilanova wrote:
>>> The existing optimizations makes it feasible to have them available on all
>>> builds.
>
>> While this change may feel trivial, I think it is a misnomer to include
>> "[trivial]" in the subject line, and I also think it should not go in
>> through qemu-trivial. The ideal trivial patch is one that can be
>> applied in isolation, but your patch can only be applied as part of a
>> series that includes the earlier optimizations that made this one possible.
>
> Ok. Does this mean I should send a new series without the trivial tag?
Probably not worth the effort this time around, unless a maintainer
specifically asks for it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature