[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 03/29] vhdx: use QEMU_ALIGN_DO
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 03/29] vhdx: use QEMU_ALIGN_DOWN |
Date: |
Thu, 13 Jul 2017 15:19:10 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/13/2017 11:31 AM, Marc-André Lureau wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> block/vhdx-log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/vhdx-log.c b/block/vhdx-log.c
> index 01278f3fc9..ad70706b99 100644
> --- a/block/vhdx-log.c
> +++ b/block/vhdx-log.c
> @@ -884,7 +884,7 @@ static int vhdx_log_write(BlockDriverState *bs,
> BDRVVHDXState *s,
> }
>
> sector_offset = offset % VHDX_LOG_SECTOR_SIZE;
> - file_offset = (offset / VHDX_LOG_SECTOR_SIZE) * VHDX_LOG_SECTOR_SIZE;
> + file_offset = QEMU_ALIGN_DOWN(offset, VHDX_LOG_SECTOR_SIZE);
>
> aligned_length = length;
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-trivial] [PATCH v2 00/29] Refactoring with clang-tidy, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 01/29] i386: use ROUND_UP macro, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 02/29] vnc: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 03/29] vhdx: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 04/29] vhost: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 05/29] i8254: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 06/29] pcspk: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 07/29] dmg: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13