|
| From: | Thomas Huth |
| Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH 16/29] lm32: use QEMU_IS_ALIGNED macro |
| Date: | Tue, 18 Jul 2017 16:37:57 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 18.07.2017 13:42, Michael Walle wrote: > Am 2017-07-18 08:09, schrieb Philippe Mathieu-Daudé: >> Applied using the Coccinelle semantic patch >> scripts/coccinelle/use_osdep.cocci >> >> Signed-off-by: Philippe Mathieu-Daudé <address@hidden> > > QEMU_IS_ALIGNED() sounds like it is used to check if a memory access is > aligned. Although it does the same, the line in question is used for > formatted output. I'm not sure if this macro should be used here. +1 I think we should not replace every usage of % blindly. It does really look wrong in this case here. Thomas
| [Prev in Thread] | Current Thread | [Next in Thread] |