Re: [Qemu-trivial] [Qemu-devel] [PATCH 19/29] disas: use QEMU_IS_ALIGNED macro

[Thomas Huth]

On 18.07.2017 13:07, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Jul 17, 2017 at 11:09 PM, Philippe Mathieu-Daudé
> <address@hidden> wrote:
>> Applied using the Coccinelle semantic patch 
>> scripts/coccinelle/use_osdep.cocci
[...]
>> diff --git a/disas.c b/disas.c
>> index d335c55bbf..8b59448286 100644
>> --- a/disas.c
>> +++ b/disas.c
>> @@ -151,7 +151,7 @@ static int print_insn_objdump(bfd_vma pc, 
>> disassemble_info *info,
>>      info->read_memory_func(pc, buf, n, info);
>>
>>      for (i = 0; i < n; ++i) {
>> -        if (i % 32 == 0) {
>> +        if (QEMU_IS_ALIGNED(i, 32)) {
>>              info->fprintf_func(info->stream, "\n%s: ", prefix);
>>          }
>>          info->fprintf_func(info->stream, "%02x", buf[i]);

This looks wrong to me. QEMU_IS_ALIGNED should be used for addresses and
similar things. This part here is about pretty printing a hex dump.

The code should likely be converted to use qemu_hexdump() instead, I guess.

 Thomas