[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-trivial] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write |
Date: |
Mon, 24 Jul 2017 20:59:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit :
> not hit since 2009! :)
>
> linux-user/elfload.c:1102:20: warning: Out of bound memory access (access
> exceeds upper limit of memory block)
> (*regs[i]) = tswap32(env->gregs[i]);
> ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> linux-user/elfload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 2a902f7806..79062882ba 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -1099,7 +1099,7 @@ static inline void
> elf_core_copy_regs(target_elf_gregset_t *regs,
> int i;
>
> for (i = 0; i < 16; i++) {
> - (*regs[i]) = tswapreg(env->gregs[i]);
> + (*regs)[i] = tswapreg(env->gregs[i]);
> }
>
> (*regs)[TARGET_REG_PC] = tswapreg(env->pc);
>
Reviewed-by: Laurent Vivier <address@hidden>
- Re: [Qemu-trivial] [Qemu-devel] [PATCH for 2.10 20/35] arm/boot: fix undefined instruction on secondary smp cpu bootloader, (continued)
[Qemu-trivial] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write, Philippe Mathieu-Daudé, 2017/07/24
- Re: [Qemu-trivial] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write,
Laurent Vivier <=
[Qemu-trivial] [PATCH for 2.10 25/35] linux-user: extract is_error() out of syscall.c, Philippe Mathieu-Daudé, 2017/07/24
[Qemu-trivial] [PATCH for 2.10 27/35] syscall: fix dereference of undefined pointer, Philippe Mathieu-Daudé, 2017/07/24
[Qemu-trivial] [PATCH for 2.10 26/35] linux-user: use is_error() to avoid warnings and make the code clearer, Philippe Mathieu-Daudé, 2017/07/24
[Qemu-trivial] [PATCH for 2.10 29/35] syscall: fix out-of-bound memory access, Philippe Mathieu-Daudé, 2017/07/24