Re: [Qemu-trivial] [PATCH for 2.10 03/35] thunk: check nb_fields is valid before continuing

[Philippe Mathieu-Daudé]

On 07/24/2017 03:37 PM, Eric Blake wrote:
> On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote:
> > thunk.c:91:32: warning: Call to 'malloc' has an allocation size of 0 bytes
> >          se->field_offsets[i] = malloc(nb_fields * sizeof(int));
> >                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Reported-by: Clang Static Analyzer
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   thunk.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
>
> Better would be fixing the code to use g_new0, and the corresponding free.

Ok, for 2.11 although (not a fix).

Also thunk* alloc'd are never free'd during process lifetime, so will 
keep like that (no g_free).