Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header

[Peter Maydell]

On 27 July 2017 at 13:02, Cleber Rosa <address@hidden> wrote:
> The generation of the informational header on config.log contains two
> pairs of single quotes, which seems unintentional, and looks like
> this:
>
>   # QEMU configure log Thu Jul 26 08:17:15 EDT 2017
>   # Configured with: './configure' '--target-list=x86_64-softmmu'

I think this is deliberate. The idea is that the string is a
validly shell-quoted string that you can cut and paste
into a shell prompt if you want to. (This is less important
than it used to be now we have config.status.)

If your configure command has more than one line you get
something like this:

# Configured with: '../../configure'
'--target-list=arm-softmmu,aarch64-softmmu,arm-linux-user,aarch64-linux-user'
'--enable-debug' '--cc=ccache gcc' '--audio-drv-list=pa'

...and note in particular how the '--cc=ccache gcc' argument
is printed. Your change would give

# Configured with: '../../configure
--target-list=arm-softmmu,aarch64-softmmu,arm-linux-user,aarch64-linux-user
--enable-debug --cc=ccache gcc --audio-drv-list=pa'

which can't be cut and pasted, and is ambiguous.

thanks
-- PMM