Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Philippe Mathieu-Daudé]

On 07/28/2017 08:50 AM, Paolo Bonzini wrote:
> On 28/07/2017 08:24, Fam Zheng wrote:
> > On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 224890643d..7854792765 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1537,6 +1537,12 @@ Checkpatch
> > >   S: Odd Fixes
> > >   F: scripts/checkpatch.pl
> > >   
> > > +Coccinelle scripts
> > > +R: Philippe Mathieu-Daudé <address@hidden>
> > > +S: Orphan
> >
> > "Orphan" sounds like we don't care much anymore but I suppose this is not the
> > case. But I don't have any better idea either.

        M: Mail patches to: FullName <address@hidden>
        R: Designated reviewer: FullName <address@hidden>

M: is mail of maintainer
R: is mail of reviewer

        S: Status, one of the following:

           Maintained:  Someone actually looks after it.
           Odd Fixes:   It has a maintainer but they don't have time
                        to do much other than throw the odd patch in.
->         Orphan:      No current maintainer

"Orphan" sounds the best fit... Do you want to raise it to "Odd Fixes"? 
This implies having a maintainer... I don't feel confident enough to Ack 
cocci scripts but an incorrect cocci script will not break QEMU so maybe 
I cat take M: for Odd Fixes, and lowering it back to Orphan without 
maintainer is 1 commit easy :)

> Just don't add it to the file.  It doesn't have a specific owner.

Paolo you mean don't add the "S: Status" to the MAINTAINERS file, or the 
"F: *cocci*" entries?

Regards,

Phil.

> Paolo
>
> > Fam
> >
> > > +F: scripts/cocci-macro-file.h
> > > +F: scripts/coccinelle/
> > > +
> > >   Migration
> > >   M: Juan Quintela <address@hidden>
> > >   M: Dr. David Alan Gilbert <address@hidden>
> > > @@ -1970,4 +1976,3 @@ Build system architecture
> > >   M: Daniel P. Berrange <address@hidden>
> > >   S: Odd Fixes
> > >   F: docs/devel/build-system.txt