qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS


From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h
Date: Mon, 25 Sep 2017 11:10:05 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 09/24/2017 08:02 PM, Daniel Loffgren wrote:
> 
> Signed-off-by: Daniel Loffgren <address@hidden>
> ---
>  include/exec/user/thunk.h | 1 +
>  1 file changed, 1 insertion(+)

meta-comment: your patch is titled 2/2, but was sent as its own
top-level thread (it is missing In-Reply-To: and References: headers).
When sending 2 patches as a series, it is important to include a 0/2
cover letter, and to properly thread things so that both 1/2 and 2/2 are
in-reply-to the 0/2 cover letter.  'git send-email' is probably the
easiest way to get this to work.  More patch submission hints at:

https://wiki.qemu.org/Contribute/SubmitAPatch

> 
> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
> index f19ef4b230..12b5449d8c 100644
> --- a/include/exec/user/thunk.h
> +++ b/include/exec/user/thunk.h
> @@ -19,6 +19,7 @@
>  #ifndef THUNK_H
>  #define THUNK_H
>  
> +#include "abitypes.h"
>  #include "cpu.h"
>  
>  /* types enums definitions */
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]