[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] io: Add missing GCC_FMT_ATTR (fix -Werror=sug
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-trivial] [PATCH] io: Add missing GCC_FMT_ATTR (fix -Werror=suggest-attribute=format) |
Date: |
Mon, 9 Oct 2017 10:27:04 +0100 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Sat, Oct 07, 2017 at 04:56:09PM +0200, Stefan Weil wrote:
> This fixes a compiler warning:
>
> /qemu/io/channel-websock.c:163:5: error:
> function might be possible candidate for ‘gnu_printf’ format attribute
> [-Werror=suggest-attribute=format]
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> io/channel-websock.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Acked-by: Daniel P. Berrange <address@hidden>
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index d1d471f86e..7bf1340958 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -151,9 +151,10 @@ enum {
> QIO_CHANNEL_WEBSOCK_OPCODE_PONG = 0xA
> };
>
> -static void qio_channel_websock_handshake_send_res(QIOChannelWebsock *ioc,
> - const char *resmsg,
> - ...)
> +static void GCC_FMT_ATTR(2, 3)
> +qio_channel_websock_handshake_send_res(QIOChannelWebsock *ioc,
> + const char *resmsg,
> + ...)
> {
> va_list vargs;
> char *response;
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|