[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 00/34] remove i386/pc dependency from non-PC w
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [PATCH 00/34] remove i386/pc dependency from non-PC world (part 1) |
Date: |
Mon, 16 Oct 2017 19:49:32 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
Hi Michael,
Thanks for your comments!
>> hw: remove "qemu/osdep.h" from header files
> not applied, doing two things, suggested split-up
> (I'm fine with it as it is)
split out MAINTAINERS entry
>> i386/hax: remove duplicated includes
> applied (note it can be trimmed more)
done in another patch.
>> misc: avoid "include/" in include path
> not applied, probably should be split, but I'm fine with it as it is
split out numa.c
>> hw/timer/i8254: rename pit_init() -> i8254_pit_init()
> not applied, split?
split out MAINTAINERS entry
>> hw/display/vga: remove the old i386/pc dependency
> somehow I can't find this patch, neither in my inbox nor in patchwork
weird...
>> hw/input/i8042: extract API from hw/i386/pc.h
> CHECK
split out MAINTAINERS entry
>> hw/dma/i8257: rename DMA_init() to i8257_dma_init()
> not applied, pending **errp addition
attempt to fix it...
>> hw/timer/m48t59: use TYPE_M48T59_ISA, add entries to MAINTAINERS
> not applied, it went out of context without i8257_dma_init rename
> btw, why do we prefer these TYPE_XXX things instead of simple "xxx" stuff?
split out MAINTAINERS entry, dropped out TYPE_M48T59_ISA use.
>> hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"
> not applied, it does more than mentioned
dropped from this series.
>> hw/net/e1000: use TYPE_PCI_E1000
>> hw/net/e1000e: use TYPE_PCI_E1000E
>> hw/net/pcnet: use TYPE_PCI_PCNET
>> hw/net/rtl8139: use TYPE_PCI_RTL8139
>> hw/net/ne2000: use TYPE_PCI_NE2000
>
> Not applied, at least not yet, why do we use these TYPE_XX stuff to
> start with?
TYPE_XX is the interface, having the devices using TYPE_XX instead of
hardcoded name guarantee safe rename/refactor.
anyway, dropped.
> Applying these series is quite a bit boring task I'd say :)
separating them from the whole branch too! but they are required for the
final objective which I'll send in 3 or 4 parts.
Regards,
Phil.