[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_T
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc |
Date: |
Wed, 18 Oct 2017 09:45:57 +0200 |
On Tue, 17 Oct 2017 13:44:18 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:
> enable_tco is specific to i386/pc.
>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> include/hw/acpi/ich9.h | 2 ++
> include/hw/i386/pc.h | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index a352c94fde..59aeb06393 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -63,6 +63,8 @@ typedef struct ICH9LPCPMRegs {
> TCOIORegs tco_regs;
> } ICH9LPCPMRegs;
>
> +#define ACPI_PM_PROP_TCO_ENABLED "enable_tco"
> +
> void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm,
> bool smm_enabled,
> qemu_irq sci_irq);
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 6335e2bf47..b1b4c918af 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -151,8 +151,6 @@ struct PCMachineClass {
> #define PC_MACHINE_CLASS(klass) \
> OBJECT_CLASS_CHECK(PCMachineClass, (klass), TYPE_PC_MACHINE)
>
> -#define ACPI_PM_PROP_TCO_ENABLED "enable_tco"
> -
> /* parallel.c */
>
> void parallel_hds_isa_init(ISABus *bus, int n);
- [Qemu-trivial] [PATCH v3 26/42] hw/ipmi: remove old i386 dependency, (continued)
- [Qemu-trivial] [PATCH v3 26/42] hw/ipmi: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 24/42] misc: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 27/42] hw/i2c: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 28/42] hw/tpm: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 29/42] hw/virtio-balloon: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 30/42] hw/unicore32: restrict hw addr defines to source file, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 31/42] hw/timer/i8254: rename pit_init() -> i8254_pit_init(), Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 33/42] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc, Philippe Mathieu-Daudé, 2017/10/17
- Re: [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc,
Igor Mammedov <=
- [Qemu-trivial] [PATCH v3 32/42] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init(), Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 35/42] hw/display/vga: "vga.h" only contains registers defs, rename it "vga_regs.h", Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 36/42] hw/display/vga: "vga_int.h" requires "ui/console.h", Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 37/42] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h", Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 39/42] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h", Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 38/42] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-trivial] [PATCH v3 40/42] i386/pc: move vmport.c to hw/i386/, Philippe Mathieu-Daudé, 2017/10/17