[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] oslib-posix: Fix compiler warning and some da
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH] oslib-posix: Fix compiler warning and some data types |
Date: |
Wed, 18 Oct 2017 17:15:56 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Oct 16, 2017 at 10:29:12PM +0200, Stefan Weil wrote:
> gcc warning:
>
> /qemu/util/oslib-posix.c:304:11: error:
> variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’
> [-Werror=clobbered]
>
> Fix also some related data types:
>
> numpages, hpagesize are used as pointer offset.
> Always use size_t for them and also for the derived
> numpages_per_thread and size_per_thread.
>
> Avoid a type cast by declaring addr volatile.
I dropped this outdated line when merging the patch.
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> v2: Fix more data types (partially as discussed with Richard)
>
> v3: Keep volatile type cast (suggested by Philippe and Paolo)
>
> Regards
> Stefan
>
> util/oslib-posix.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan