[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hmp: Replace error_report_err
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-trivial] [PATCH] hmp: Replace error_report_err |
Date: |
Thu, 19 Oct 2017 12:24:56 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* ZhiPeng Lu (address@hidden) wrote:
> Use hmp_handle_error instend of error_report_err to set error.
>
> Signed-off-by: ZhiPeng Lu <address@hidden>
> Reviewed-by: Jiyun Fan <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp.c | 26 ++++++++------------------
> 1 file changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index ec61329..a03bd03 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -667,7 +667,7 @@ void hmp_info_vnc(Monitor *mon, const QDict *qdict)
>
> info2l = qmp_query_vnc_servers(&err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
> if (!info2l) {
> @@ -782,7 +782,7 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
>
> info = qmp_query_balloon(&err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
>
> @@ -1125,7 +1125,7 @@ void hmp_ringbuf_read(Monitor *mon, const QDict *qdict)
>
> data = qmp_ringbuf_read(chardev, size, false, 0, &err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
>
> @@ -1192,9 +1192,7 @@ void hmp_balloon(Monitor *mon, const QDict *qdict)
> Error *err = NULL;
>
> qmp_balloon(value, &err);
> - if (err) {
> - error_report_err(err);
> - }
> + hmp_handle_error(mon, &err);
> }
>
> void hmp_block_resize(Monitor *mon, const QDict *qdict)
> @@ -1518,10 +1516,7 @@ void hmp_migrate_set_cache_size(Monitor *mon, const
> QDict *qdict)
> Error *err = NULL;
>
> qmp_migrate_set_cache_size(value, &err);
> - if (err) {
> - error_report_err(err);
> - return;
> - }
> + hmp_handle_error(mon, &err);
> }
>
> /* Kept for backwards compatibility */
> @@ -1552,10 +1547,7 @@ void hmp_migrate_set_capability(Monitor *mon, const
> QDict *qdict)
>
> end:
> qapi_free_MigrationCapabilityStatusList(caps);
> -
> - if (err) {
> - error_report_err(err);
> - }
> + hmp_handle_error(mon, &err);
> }
>
> void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
> @@ -1653,9 +1645,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const
> QDict *qdict)
> cleanup:
> qapi_free_MigrateSetParameters(p);
> visit_free(v);
> - if (err) {
> - error_report_err(err);
> - }
> + hmp_handle_error(mon, &err);
> }
>
> void hmp_client_migrate_info(Monitor *mon, const QDict *qdict)
> @@ -1909,7 +1899,7 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
>
> qmp_migrate(uri, !!blk, blk, !!inc, inc, false, false, &err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK