[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 0/4] tpm: add stubs to fix compiling with -
From: |
Amarnath Valluri |
Subject: |
Re: [Qemu-trivial] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm |
Date: |
Tue, 24 Oct 2017 21:19:22 +0300 |
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> This fixes building with --disable-tpm as reported by Zoltan:
> http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html
>
> Cc'ing Peter in case this enters as a build fix instead of via trivial.
>
> v2:
> - added Richard W.M. Jones Tested-by tag
> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)
>
> Regards,
>
> Phil.
>
> PD: I missed Amarnath Valluri in my first series, you might want to add
> yourself
> a R: tag in MAINTAINTERS.
>
> Philippe Mathieu-Daudé (4):
> tpm: add missing include
> tpm: add stubs
> tpm: remove unnecessary #ifdef CONFIG_TPM
> vl: remove unnecessary #ifdef CONFIG_TPM
>
> Makefile.objs | 2 +-
> include/sysemu/tpm.h | 1 +
> stubs/tpm.c | 33 +++++++++++++++++++++++++++++++++
> tpm.c | 4 ----
> vl.c | 2 --
> MAINTAINERS | 1 +
> stubs/Makefile.objs | 1 +
> 7 files changed, 37 insertions(+), 7 deletions(-)
> create mode 100644 stubs/tpm.c
>
+1, Nice cleanup in my opinion, now it looks much cleaner.
- Amarnath
- Re: [Qemu-trivial] [PATCH v2 2/4] tpm: add stubs, (continued)