Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

[Peter Maydell]

On 4 December 2017 at 15:51, Max Reitz <address@hidden> wrote:
> On 2017-12-02 23:37, Shravan Rajinikanth wrote:
>> Signed-off-by: Shravan Rajinikanth <address@hidden>
>> ---
>>  qemu-img.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 68b375f..bea9268 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, 
>> bool quiet)
>>          if (check->leaks) {
>>              qprintf(quiet,
>>                      "\n%" PRId64 " leaked clusters were found on the 
>> image.\n"
>> -                    "This means waste of disk space, but no harm to 
>> data.\n",
>> +                    "This means disk space is wasted, but data is safe.\n",
>>                      check->leaks);
>>          }
>
> How exactly is this a grammatical error?  (I'm not a native English
> speaker, but it always seemed perfectly OK to me)

I think "This means" more naturally takes a verb phrase, not a noun phrase.
I don't know that I'd go so far as to say that the current text is
ungrammatical, but I do think the proposed change sounds more natural to me.

thanks
-- PMM