qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not


From: John Snow
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure
Date: Mon, 4 Dec 2017 11:59:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0


On 12/01/2017 01:31 PM, Michael McConville wrote:
> Signed-off-by: Michael McConville <address@hidden>
> ---
>  hw/i386/xen/xen-mapcache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> index baab93b614..efa35dc6e0 100644
> --- a/hw/i386/xen/xen-mapcache.c
> +++ b/hw/i386/xen/xen-mapcache.c
> @@ -199,7 +199,7 @@ static void xen_remap_bucket(MapCacheEntry *entry,
>           */
>          vaddr_base = mmap(vaddr, size, PROT_READ | PROT_WRITE,
>                            MAP_ANON | MAP_SHARED, -1, 0);
> -        if (vaddr_base == NULL) {
> +        if (vaddr_base == MAP_FAILED) {
>              perror("mmap");
>              exit(-1);
>          }
> 

Reviewed-by: John Snow <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]