[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] hw/rdma: Use correct print f
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] hw/rdma: Use correct print format in CHK_ATTR macro |
Date: |
Thu, 22 Mar 2018 05:26:03 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/21/2018 06:10 PM, Yuval Shaia wrote:
> Macro should not cast the given variable to u64 instead it should use
> the supplied format argument (fmt).
>
> Reported-by: Eric Blake <address@hidden>
> Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/rdma/rdma_backend.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> index f1a37ba4a2..0391a7dd95 100644
> --- a/hw/rdma/rdma_backend.c
> +++ b/hw/rdma/rdma_backend.c
> @@ -656,8 +656,8 @@ void rdma_backend_destroy_qp(RdmaBackendQP *qp)
> #define CHK_ATTR(req, dev, member, fmt) ({ \
> pr_dbg("%s="fmt","fmt"\n", #member, dev.member, req->member); \
> if (req->member > dev.member) { \
> - warn_report("%s = 0x%lx is higher than host device capability
> 0x%lx", \
> - #member, (uint64_t)req->member, (uint64_t)dev.member); \
> + warn_report("%s = "fmt" is higher than host device capability "fmt, \
> + #member, req->member, dev.member); \
> req->member = dev.member; \
> } \
> pr_dbg("%s="fmt"\n", #member, req->member); })
>
- [Qemu-trivial] [PATCH 0/3] hw/rdma: Fix 32-bit compilation, Yuval Shaia, 2018/03/21
- [Qemu-trivial] [PATCH 1/3] hw/rdma: Change host_virt to void *, Yuval Shaia, 2018/03/21
- [Qemu-trivial] [PATCH 2/3] hw/rdma: Use correct print format in CHK_ATTR macro, Yuval Shaia, 2018/03/21
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] hw/rdma: Use correct print format in CHK_ATTR macro,
Philippe Mathieu-Daudé <=
- [Qemu-trivial] [PATCH 3/3] hw/rdma: Fix 32-bit compilation, Yuval Shaia, 2018/03/21
- Re: [Qemu-trivial] [PATCH 0/3] hw/rdma: Fix 32-bit compilation, Eric Blake, 2018/03/21
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation, no-reply, 2018/03/22