[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-block] [PATCH 3/5] qemu-img: remove references
From: |
Jeff Cody |
Subject: |
Re: [Qemu-trivial] [Qemu-block] [PATCH 3/5] qemu-img: remove references to GEN_DOCS |
Date: |
Tue, 8 May 2018 11:45:01 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, May 03, 2018 at 06:56:46PM -0400, John Snow wrote:
> Nothing seemingly uses this.
>
Indeed - it looks like it has been vestigial for a while now (commit
77bd1119ba even mentions that it appears unused).
Reviewed-by: Jeff Cody <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
> qemu-img.c | 2 --
> qemu-options-wrapper.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 855fa52514..a01425372d 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -123,7 +123,6 @@ static void QEMU_NORETURN help(void)
> " " arg_string "\n"
> #include "qemu-img-cmds.h"
> #undef DEF
> -#undef GEN_DOCS
> "\n"
> "Command parameters:\n"
> " 'filename' is a disk image filename\n"
> @@ -4685,7 +4684,6 @@ static const img_cmd_t img_cmds[] = {
> { option, callback },
> #include "qemu-img-cmds.h"
> #undef DEF
> -#undef GEN_DOCS
> { NULL, NULL, },
> };
>
> diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h
> index 13bfea0294..6f548e3922 100644
> --- a/qemu-options-wrapper.h
> +++ b/qemu-options-wrapper.h
> @@ -34,7 +34,6 @@
> #undef DEF
> #undef DEFHEADING
> #undef ARCHHEADING
> -#undef GEN_DOCS
>
> #undef QEMU_OPTIONS_GENERATE_ENUM
> #undef QEMU_OPTIONS_GENERATE_HELP
> --
> 2.14.3
>
>
- [Qemu-trivial] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent, John Snow, 2018/05/03
- [Qemu-trivial] [PATCH 3/5] qemu-img: remove references to GEN_DOCS, John Snow, 2018/05/03
- Re: [Qemu-trivial] [Qemu-block] [PATCH 3/5] qemu-img: remove references to GEN_DOCS,
Jeff Cody <=
- [Qemu-trivial] [PATCH 5/5] qemu-img-cmds.hx: add passive-aggressive note, John Snow, 2018/05/03
- [Qemu-trivial] [PATCH 1/5] qemu-img-commands.hx: argument ordering fixups, John Snow, 2018/05/03
- [Qemu-trivial] [PATCH 2/5] qemu-img.texi: fix command ordering, John Snow, 2018/05/03
- [Qemu-trivial] [PATCH 4/5] qemu-img: Make documentation between .texi and .hx consistent, John Snow, 2018/05/03
- Re: [Qemu-trivial] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent, John Snow, 2018/05/03