[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v4 09/21] target: Do not include "exec/exec-al
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-trivial] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary |
|
Date: |
Wed, 30 May 2018 00:12:55 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Hi Cornelia,
On 05/29/2018 08:40 AM, Cornelia Huck wrote:
> On Mon, 28 May 2018 20:27:07 -0300
> Philippe Mathieu-Daudé <address@hidden> wrote:
>
>> Code change produced with:
>> $ git grep '#include "exec/exec-all.h"' | \
>> cut -d: -f-1 | \
>> xargs egrep -L
>> "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)"
>> | \
>
> Hm, does this expression catch all files that need to include
> exec-all.h? The resulting patch seems fine, though.
No, not all :/
I started with "(cpu_loop_|tlb_|tb_)" then kept brutebuilding until no
more errors appear. In 2 more steps I added "cpu_address_space_init|"
then "|GETPC|singlestep|TranslationBlock". Quick and dirty enough for my
goal than trying to build a regex to explode function/struct names from
headers. This is a clever way to do it for long term command reuse taken
from commit messages...
>> xargs sed -i.bak '/#include "exec\/exec-all.h"/d'
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
- Re: [Qemu-trivial] [PATCH v4 03/21] target: Do not include "exec/address-spaces.h" if it is not necessary, (continued)
- [Qemu-trivial] [PATCH v4 04/21] memory: Do not include "exec/ioport.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
- [Qemu-trivial] [PATCH v4 05/21] target/i386: Do not include "exec/ioport.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
- [Qemu-trivial] [PATCH v4 06/21] target/xtensa: Include "qemu/timer.h" to use NANOSECONDS_PER_SECOND, Philippe Mathieu-Daudé, 2018/05/28
- [Qemu-trivial] [PATCH v4 07/21] target/ppc: Include "exec/exec-all.h" which provides tlb_flush(), Philippe Mathieu-Daudé, 2018/05/28
- [Qemu-trivial] [PATCH v4 08/21] target/hppa: Include "qemu/log.h" to use qemu_log(), Philippe Mathieu-Daudé, 2018/05/28
- [Qemu-trivial] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
- [Qemu-trivial] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
Re: [Qemu-trivial] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary, Cornelia Huck, 2018/05/30
[Qemu-trivial] [PATCH v4 11/21] hw: Do not include "exec/address-spaces.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 13/21] hw: Do not include "sysemu/blockdev.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 14/21] hw: Do not include "sysemu/blockdev.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28