[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-options: Add missing newlin
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-options: Add missing newline to -accel help text |
|
Date: |
Mon, 11 Jun 2018 15:05:23 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/11/2018 02:56 PM, Eduardo Habkost wrote:
The newline was removed by commit c97d6d2c, and broke -help output:
-help output is not supposed to be parsed by machine, in part because of
stuff like this ;)
Before this patch:
$ qemu-system-x86_64 -help | grep smp
thread=single|multi (enable multi-threaded TCG)-smp [...]
After this patch:
$ qemu-system-x86_64 -help | grep smp
-smp
[cpus=]n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets]
Fixes: c97d6d2cdf97edb4aebe832fdba65d701ad7bcb6
Cc: Sergio Andres Gomez Del Real <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
But for the humans, this is a definite mistake worth fixing.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org