[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC bin
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions |
|
Date: |
Tue, 12 Jun 2018 10:51:59 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote:
> xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename
> \"%s\","
> - " size %" PRId64 " (%" PRId64 " MB)\n",
> + " size %" PRId64 " (%llu MB)\n",
> blkdev->type, blkdev->fileproto, blkdev->filename,
> - blkdev->file_size, blkdev->file_size >> 20);
> + blkdev->file_size, blkdev->file_size / MiB);
Having to change printf markup is exactly why you shouldn't use ULL in MiB.
r~
- Re: [Qemu-trivial] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions, (continued)
- [Qemu-trivial] [PATCH v4 05/40] hw: Use IEC binary prefix definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 08/40] hw/ipack: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 09/40] hw/scsi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 10/40] hw/smbios: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions,
Richard Henderson <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Eric Blake, 2018/06/12
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Richard Henderson, 2018/06/12
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Eric Blake, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Richard Henderson, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/13
[Qemu-trivial] [PATCH v4 12/40] hw/tpm: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
[Qemu-trivial] [PATCH v4 13/40] hw/block: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
[Qemu-trivial] [PATCH v4 15/40] hw/misc: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
[Qemu-trivial] [PATCH v4 16/40] hw/riscv: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10