[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH v5 43/46] vl: Use the IEC binary prefix definition
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-trivial] [PATCH v5 43/46] vl: Use the IEC binary prefix definitions |
Date: |
Mon, 25 Jun 2018 09:42:35 -0300 |
It eases code review, unit is explicit.
Patch generated using:
$ git grep -n '[<>][<>]= ?[1-5]0'
and modified manually.
Suggested-by: Eric Blake <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
vl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index d451f45dc5..7729ba390f 100644
--- a/vl.c
+++ b/vl.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/units.h"
#include "qapi/error.h"
#include "qemu-version.h"
#include "qemu/cutils.h"
@@ -2790,7 +2791,7 @@ static void set_memory_options(uint64_t *ram_slots,
ram_addr_t *maxram_size,
if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) {
uint64_t overflow_check = sz;
- sz <<= 20;
+ sz *= MiB;
if ((sz >> 20) != overflow_check) {
error_report("too large 'size' option value");
exit(EXIT_FAILURE);
--
2.18.0
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v5 36/46] hw/sd: Use the IEC binary prefix definitions, (continued)
- [Qemu-trivial] [PATCH v5 37/46] hw/vfio: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 38/46] hw/virtio: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 39/46] hw/rdma: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 40/46] cutils: Do not include "qemu/units.h" directly, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 41/46] hw/ppc: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 42/46] monitor: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 43/46] vl: Use the IEC binary prefix definitions,
Philippe Mathieu-Daudé <=
- [Qemu-trivial] [PATCH v5 44/46] tests/crypto: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 46/46] bsd-user: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- [Qemu-trivial] [PATCH v5 45/46] linux-user: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
- Re: [Qemu-trivial] [PATCH v5 00/46] Use the IEC binary prefix definitions, Michael S. Tsirkin, 2018/06/25
- Message not available