qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] hw/machine: Remove the Zero check of nb_numa_


From: Igor Mammedov
Subject: Re: [Qemu-trivial] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up
Date: Tue, 10 Jul 2018 14:06:55 +0200

On Tue, 10 Jul 2018 18:51:29 +0800
Dou Liyang <address@hidden> wrote:

> This Commit 7747abf11487 misses the curly brackets. Follow Igor's and 
> Eduardo's suggestion,
> 
> Add a follow-up patch for it.
> 
> Signed-off-by: Dou Liyang <address@hidden>
> ---
>  hw/core/machine.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index a9aeb22f03..6b68e1218f 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -793,8 +793,9 @@ void machine_run_board_init(MachineState *machine)
>      MachineClass *machine_class = MACHINE_GET_CLASS(machine);
>  
>      numa_complete_configuration(machine);
> -    if (nb_numa_nodes)
> +    if (nb_numa_nodes) {
>          machine_numa_finish_cpu_init(machine);
> +    }
>  
>      /* If the machine supports the valid_cpu_types check and the user
>       * specified a CPU with -cpu check here that the user CPU is supported.

Reviewed-by: Igor Mammedov <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]