[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/qdev-core: Fix description of instance_ini
From: |
Andreas Färber |
Subject: |
Re: [Qemu-trivial] [PATCH] hw/qdev-core: Fix description of instance_init |
Date: |
Mon, 10 Sep 2018 13:44:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Am 10.09.18 um 10:09 schrieb Thomas Huth:
> The part of the documentation of DeviceClass that talks about instance_init
> is partly wrong: instance_init() functions must not abort or exit, since
> the function is also called during introspection of the device already.
> So if a device calls exit() during its instance_init() function, QEMU
> terminates unexpectedly if somebody tries to just have a look at the
> interfaces from the device with "device_add xyz,help" or with the
> "device-list-properties" QOM command. This should never happen.
>
> Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)